Skip to content

ci: update Windows CI jobs to use Node.js 24 for test execution #32356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: update Windows CI jobs to use Node.js 24 for test execution #32356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ jobs:
run: |
pnpm bazel build \
--config=e2e \
//tests:e2e.webpack_node22 \
//tests:e2e.esbuild_node22 \
//tests:e2e.webpack_node24 \
//tests:e2e.esbuild_node24 \
--platforms=tools:windows_x64
- name: Store built Windows E2E tests
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
Expand All @@ -131,7 +131,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [22]
node: [24]
subset: [esbuild, webpack]
shard: [0, 1, 2, 3, 4, 5]
runs-on: windows-2025
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
run: |
pnpm bazel build \
--config=e2e \
//tests:e2e.esbuild_node22 \
//tests:e2e.esbuild_node24 \
--platforms=tools:windows_x64
- name: Store built Windows E2E tests
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
- name: Run CLI E2E tests
uses: ./.github/shared-actions/windows-bazel-test
with:
test_target_name: e2e.esbuild_node22
test_target_name: e2e.esbuild_node24
env:
E2E_SHARD_TOTAL: 1
TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild,serve}.ts
Expand Down