Fix issues and improve codebase #1646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several issues found during a codebase review:
- Fix typo in README.md ("a two simple" -> "two simple").
- Fix bug in face_landmarks function in face_recognition/api.py:
- Added checks for point indices to prevent IndexError.
- Return empty lists for top_lip and bottom_lip if critical points are missing.
- Fix code comment discrepancy in batch_face_locations in face_recognition/api.py.
- Improve tests in tests/test_face_recognition.py:
- Added more specific assertions for 'large' model landmarks.
- Added test for 'small' model landmark keys.
- Added test for invalid model name in face_landmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses several issues found during a codebase review: