Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Feb 29, 2024

Description:
The setAttribute method in <a-scene> prioritizes systems over components and other attributes. However, it did this by checking if the attribute name was present in the object with initialized systems. When programmatically creating an a-scene these might not have been initialized yet.

This PR changes the condition to first check if the attribute name matches a registered system.

Fixes: #3211

Changes proposed:

  • Check if attribute name matches a registered system in setAttribute
  • Introduce unit tests for checking <a-scene>'s setAttribute

@dmarcos
Copy link
Member

dmarcos commented Mar 6, 2024

Thanks!

@dmarcos dmarcos merged commit 0623abc into aframevr:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

document how to disable default lights on dynamically inserted scenes

2 participants