keep components attached to entity if whole entity is detached (fixes #4027) #4121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Preserves component data if entity is detached so entity could be reattached okay. If entity is detached, it should run component pause/remove callbacks, but can still keep the component reference + data.
If a component is explicitly removed, then we destroy the component and its data.
Entity.destroy()? If this use case is supported (detach entity and attach somewhere else in scenegraph), then do we need components to have a separate destroy handler? Or do we just not callComponent.removeunless it is being destroyed and count theremoveas the destroy handler.Changes Proposed:
Entity.destroy()method for when you detach an entity and never want to use it anymore, you can call the.destroy()method.