Emit event when a headset is connected #3918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
reviewed
Dec 16, 2018
src/utils/device.js
Outdated
| device.supportsSession({immersive: true, exclusive: true}).then(function () { | ||
| var sceneEl = document.querySelector('a-scene'); | ||
| vrDisplay = device; | ||
| if (sceneEl) { sceneEl.emit('headsetconnected', {vrDisplay: vrDisplay}); } |
Member
Author
There was a problem hiding this comment.
It's used similarly to checkHeadsetConnected from utils
Member
|
r+wc |
dmarcos
force-pushed
the
headsetconnected
branch
from
dea0ba3 to
80d0738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigator.getVRDisplays(WebVR) andnavigator.xr.requestDevice(WebXR) are both asynchronous. An event makes easier to detect when a headset is connected and implement enter VR UIs / workflows.