add vertexColors to base material properties #2901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Jul 27, 2017
| | shader | Which material to use. Defaults to the [standard material][standard]. Can be set to the [flat material][flat] or to a registered custom material. | standard | | ||
| | side | Which sides of the mesh to render. Can be one of `front`, `back`, or `double`. | front | | ||
| | transparent | Whether material is transparent. Transparent entities are rendered after non-transparent entities. | false | | ||
| | vertexColors | Whether to use vertex or face colors to shade the material. Can be one of `none`, `vertex`, or `face`. | none | |
Member
There was a problem hiding this comment.
Is vertexColors a good name for the property? What about geometryColoring, geometryShading....?
Member
There was a problem hiding this comment.
I don't like the name either but I agree that if we're consistent with three.js we should keep using it https://github.com/mrdoob/three.js/blob/dev/src/materials/Material.js#L27 :\
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow for vertex or face coloring.