when selecting element by id in selectorParse, use getElementById instead of querySelector for better performance #2820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of querySelector for better performance (https://jsperf.com/getelementbyid-vs-queryselector), and this way it also support id that starts with a digit (querySelector doesn’t support that)
Member
|
Thanks! Almost ready to go. There's a broken test to fix |
Contributor
Author
|
Fixed. |
ngokevin
reviewed
Jun 26, 2017
src/core/propertyTypes.js
Outdated
| function selectorParse (value) { | ||
| if (!value) { return null; } | ||
| if (typeof value !== 'string') { return value; } | ||
| if (value[0] === '#' && !/[.,[: ]/.test(value)) { |
Contributor
Author
There was a problem hiding this comment.
that's to check if the query is '#someId.someClass div[name="b"]' etc.
Contributor
Author
There was a problem hiding this comment.
I've updated the regex
Member
|
I've updated to fix tests, added tests for selectors that were not accounted for, fixed the regex. |
Member
|
thanks much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when selecting element by id in selectorParse, use getElementById instead of querySelector for better performance (https://jsperf.com/getelementbyid-vs-queryselector), and this way it also support id that starts with a digit (querySelector doesn’t support that)