Skip to content

update syntax for vive-controls model for 0.4.0 #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmarcos merged 1 commit into from
Dec 20, 2016
Merged

update syntax for vive-controls model for 0.4.0 #2194

dmarcos merged 1 commit into from
Dec 20, 2016

Conversation

@machenmusik
Copy link
Contributor

@machenmusik machenmusik commented Dec 20, 2016

Fixes #2190

@machenmusik machenmusik mentioned this pull request Dec 20, 2016
Closed
@machenmusik
Copy link
Contributor Author

machenmusik commented Dec 20, 2016 •
edited
Loading

@dmarcos @ngokevin looks like 0.4.0 model syntax changed and broke prior vive-controls model usage; for those that were using its built-in model, this is an important fix

@dmarcos
Copy link
Member

dmarcos commented Dec 20, 2016

Thanks!

@dmarcos dmarcos merged commit d0225ad into aframevr:master Dec 20, 2016
@ngokevin ngokevin mentioned this pull request Dec 20, 2016
Merged
ngokevin pushed a commit to pulilab/aframe that referenced this pull request Feb 6, 2017
@machenmusik @ngokevin
update syntax for vive-controls model for 0.4.0 (aframevr#2194)
9971093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@machenmusik @dmarcos