Allows defining multiple compoenents of a specific type on a single e… #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/a-entity.js
Outdated
| if (name in this.components) { return; } | ||
| component = this.components[name] = new components[name].Component(this, data); | ||
| if (id && !components[name].multiple) { | ||
| throw new Error('Trying to initialize multiple components of type ' + name + |
Member
There was a problem hiding this comment.
can we indent like we do here: https://github.com/aframevr/aframe/pull/1596/files#diff-dc3043915bc0e1dc643b7fa488e01c0eR254
Member
|
I found |
dmarcos
force-pushed
the
multipleComponents
branch
2 times, most recently
from
f9eb1cf to
fd97cfd
Compare
src/core/a-entity.js
Outdated
| value: function (attrName, data, isDependency) { | ||
| var component; | ||
| var isComponentDefined = checkComponentDefined(this, name) || data !== undefined; | ||
| var componentInfo = attrName.split('__'); |
Member
There was a problem hiding this comment.
Probably good to make a constant for this.
MULTI_DELIMITER = '__';
Member
|
Add test for r+wc |
dmarcos
force-pushed
the
multipleComponents
branch
from
fd97cfd to
6bdce07
Compare
Member
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.