allow system configuration (fixes #1464) #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
changed the title
src/core/a-entity.js
Outdated
|
|
||
| // If attribute is not a component or if attribute is a system for the scene. | ||
| // If attribute is a system that exists for the scene, then we ignore the component. | ||
| if (!components[attr] || (this.isScene && systems[attr])) { |
Member
There was a problem hiding this comment.
This code should probably be part of a a-scene implementation of setAttribute
ngokevin
force-pushed
the
systemschema
branch
2 times, most recently
from
d836ade to
2eddbd7
Compare
ngokevin
changed the title
Member
|
@fernandojsg Do you see any problem with the editor handling this? |
Member
|
After this change I'm starting to think that A-Frame should prescribe a physics engine for 0.4.0. You want one that works well and integrates consistently with components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Configurable systems. Use cases so far have been configurable Firebase system for API credentials, and configurable Physics system such as for gravity.
So far we've had to work around using proxy components.
Currently does not support updates.
Changes proposed:
Scene.getAttributeandScene.setAttributeto return system data (if exists) rather than component data that might have the same name (e.g., if you had aphysicssystem andphysicscomponent,sceneEl.getAttribute('physics')should return physics system data.