Skip to content

Create new instance of THREE.ColladaLoader on collada-model init #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ngokevin merged 1 commit into from
May 28, 2016
Merged

Create new instance of THREE.ColladaLoader on collada-model init #1511

ngokevin merged 1 commit into from
May 28, 2016

Conversation

@iandeboisblanc
Copy link
Contributor

@iandeboisblanc iandeboisblanc commented May 28, 2016

Description:
Fixes #1510. Creates new instance of collada loader for each collada-model component to prevent issue where using multiple collada models causes them to render incorrectly.

Changes proposed:

  • Move new 'THREE.ColladaLoader()' from outside component registration to within init method of collada-model component

@ngokevin
Copy link
Member

ngokevin commented May 28, 2016

Thanks!

@ngokevin ngokevin merged commit 943dc09 into aframevr:master May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iandeboisblanc @ngokevin