Skip to content

Conversation

@sjando
Copy link

@sjando sjando commented May 3, 2016

Description:

The way three.js examples (loaders, controls, effects) are currently required with an explicit node_modules path breaks the ability to build aframe from source when aframe is installed as a dependency with npm3 (flat dependency structure). This scenario should be supported given requiring from source instead of prebuilt is sometimes more appropriate (e.g. avoiding duplicate THREE object in prebuilt file if another three dependency exists in the project outside of aframe)

Changes proposed:

  • Do not provide explicit node_modules path, allowing browserify/webpack/etc to find the appropriate three location

@ngokevin
Copy link
Member

ngokevin commented May 4, 2016

Thanks!

@ngokevin ngokevin merged commit a54d1cb into aframevr:master May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants