Skip to content

Create a torus primitve #155 #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ngokevin merged 1 commit into from
Mar 22, 2016
Merged

Create a torus primitve #155 #1184

ngokevin merged 1 commit into from
Mar 22, 2016

Conversation

@IagoLast
Copy link
Contributor

@IagoLast IagoLast commented Mar 16, 2016

Torus primitive was implemented, notice that tube attribute is not working yet, probably (not sure) because is not included in geometry schema.

I´ve created a simple example:
torus

(yep, it´s a face ^^)

@IagoLast IagoLast changed the title Create a torus primitve #155 Create a torus primitve #156 Mar 16, 2016
@IagoLast IagoLast changed the title Create a torus primitve #156 Create a torus primitve #155 Mar 16, 2016
@dmarcos
Copy link
Member

dmarcos commented Mar 17, 2016

looks good to me. @ngokevin?

@dmarcos
Copy link
Member

dmarcos commented Mar 17, 2016

@IagoLast thanks a lot! can you squash your commits?

@ngokevin
Copy link
Member

ngokevin commented Mar 17, 2016

tube is radiusTubular

ngokevin
ngokevin reviewed Mar 17, 2016
View reviewed changes
docs/primitives/a-torus.md Outdated

## Attributes

Note that the box primitive inherits common [mesh attributes](./mesh-attributes.md).
Copy link
Member

@ngokevin ngokevin Mar 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/box/torus

@ngokevin
Copy link
Member

ngokevin commented Mar 17, 2016

Thanks for doing this!

ngokevin
ngokevin reviewed Mar 19, 2016
View reviewed changes
src/extras/primitives/primitives/a-torus.js Outdated

mappings: {
'radius': 'geometry.radius',
'tube': 'geometry.radiusTubular',
Copy link
Member

@ngokevin ngokevin Mar 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this as radius-tubular

@IagoLast
Create a torus primitve (#155)
d326d80 
  - Add torus primitive
  - Add torus basic example
  - Add torus doc
  - Pull request fixes
@ngokevin
Copy link
Member

ngokevin commented Mar 22, 2016

Thanks! I'm gonna make a few small changes myself in another commit.

ngokevin added a commit that referenced this pull request Mar 22, 2016
@ngokevin
Merge pull request #1184 from IagoLast/master
a96a01b 
Create a `torus` primitive #155
@ngokevin ngokevin merged commit a96a01b into aframevr:master Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IagoLast @dmarcos @ngokevin