Skip to content

Conversation

@rothej
Copy link

@rothej rothej commented Nov 29, 2025

Added unit tests in tests/util/test_modelwrapper.py. All pre-commit hooks pass, new unit tests verify the helper methods works

… get_global_in/out methods. Added unit test tests/util/test_modelwrapper.py

Signed-off-by: Joshua Rothe <joshrothe@gmail.com>
@rothej rothej changed the base branch from main to dev November 29, 2025 03:55
@rothej rothej marked this pull request as draft November 29, 2025 22:22
…sing failures when running quicktest in docker

Signed-off-by: Joshua Rothe <joshrothe@gmail.com>
@rothej rothej marked this pull request as ready for review November 29, 2025 22:35
@rothej rothej marked this pull request as draft November 29, 2025 22:50
Signed-off-by: Joshua Rothe <joshrothe@gmail.com>
@rothej rothej marked this pull request as ready for review November 29, 2025 22:58
@rothej
Copy link
Author

rothej commented Nov 29, 2025

Using ./run-docker.sh quicktest, results are:

= 1163 passed, 16 skipped, 5 xfailed, 1 xpassed, 77462 warnings in 66.39s (0:01:06) =

All instances of old pattern were replaced with the new pattern in the codebase.

@auphelia
Copy link
Collaborator

Hi @rothej,
Thank you for picking up this open issue! This issue dates back to when the modelwrapper (https://github.com/fastmachinelearning/qonnx/blob/main/src/qonnx/core/modelwrapper.py) was still part of FINN. As you can see from the link, it’s now part of qonnx.

Since it is defined in qonnx, the usual workflow is:

Would you mind following that structure and first creating a PR to qonnx main that adds those new class methods, instead of adding them on top of modelwrapper inside FINN? I’m sure other users would also appreciate having those new class methods available directly in qonnx.

@rothej
Copy link
Author

rothej commented Dec 11, 2025

@auphelia not a problem! I'll go ahead and do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants