Feature: integrate pycirclize into UltraPlot #495
+1,415
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvanelteren
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
cvanelteren
force-pushed
the
add-chord-diagram
branch
from
c1d12fb to
e0a3d1c
Compare
cvanelteren
commented
Jan 24, 2026
pyproject.toml
Outdated
|
|
||
| [project.optional-dependencies] | ||
| circos = ["pycirclize>=1.10.1"] | ||
| all = ["pycirclize>=1.10.1"] |
Collaborator
Author
There was a problem hiding this comment.
Need to work on this a bit -- do we want to provide a minimal install and all bells and whizzles? I guess for people (like me) that does not use geo this may be nice to reduce the disk space
Collaborator
Author
There was a problem hiding this comment.
Will change this to have default install everything and instead add a minimal installer
ultraplot/tests/test_plot.py
Outdated
| from ultraplot.axes.plot_types.circlize import _import_pycirclize | ||
|
|
||
| _import_pycirclize() | ||
| except ImportError: |
Collaborator
Author
There was a problem hiding this comment.
I think this is overkill and too specific to how this was developed
Collaborator
Author
There was a problem hiding this comment.
hmm on second thought maybe this is ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will integrated pycirclize into UltraPlot exposing chord diagrams, radar plots, and phylogeny plot. It wraps PyCirclize into an UltraPlot flavored manner adding the convenience of normal plotting while harnessing the strenghts of this well developed package.
Putting this in draft for now but it seems to work nicely with main
Closes #472