fix: opening suggestion menu in collab mode on empty document #2338
+27
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug that hitting the + button doesn't work in collaboration mode, on an empty document. I tried to address it here but didn't get to the root cause yet.
In this PR, I have:
However, this doesn't fix the issue yet. I think there's an issue with using
trackPositionin this specific case.We can diagnose further by adding a breakpoint in the if-statement marked by
// Checks if the menu should be hidden.