fix(core): add new launch.json and fixed breakpoints not working #599
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| : useElementSize(computed(() => toValue(canvas).parentElement)) | ||
| : useElementSize( | ||
| computed( | ||
| () => toValue(canvas).parentElement, |
There was a problem hiding this comment.
Hi @alvarosabu There is an issue when the TresCanvas uses the parent element width and height.
The usElementSize composable from VueUse loses its reactivity I assume which causes the TresCanvas width and height to be 0.
This issue occurs when you hit a breakpoint and continue debugging after. When you use the useWindowSize prop this doesn't happen.
This fixes that
There was a problem hiding this comment.
@ThimoDEV would be possible to have this change in a separate PR, is a little bit confusing to understand the scope of this one.
alvarosabu
added
investigation
needs-test
p2-nice-to-have
|
@alvarosabu Is there anything more you need/changed for this to be merged? So I can help get you there :) |
| : useElementSize(computed(() => toValue(canvas).parentElement)) | ||
| : useElementSize( | ||
| computed( | ||
| () => toValue(canvas).parentElement, |
There was a problem hiding this comment.
@ThimoDEV would be possible to have this change in a separate PR, is a little bit confusing to understand the scope of this one.
|
Hi @alvarosabu , The change was needed because of HMR. When you go into a breakpoint and want to continue you expect the canvas to render what was last there. However without this change it would freeze and you would have to restart the debugger completely |
2 participants
This PR adds a new launch.json so a maintainer of TresJS can use breakpoints during development.
How to use?
pnpm playgroundRun and debugwindowI had this weird issue where the localhost url wasn't working. I set the port on all to 3000 which seems to make the dev server more stable. I don't know if this impacts releases in any way?