unify(texture): Merge W3DWater and WW3D2 texture code #1989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Merge with Rebase
This change has 2 commits.
The first commit merges texture related changes from Zero Hour to Generals. It also fully merges W3DWater and W3DWaterTracks, because the water was not drawn otherwise. The second commit moves the relevant merged files to Core.
Generals gets the following things as documented by EA
Note
I did not attempty to decouple the individual EA changes, because the change complexity is too large. I simply copied everything texture related from Zero Hour to Generals as is. I think the complexit of this merge is reasonable for what it is trying to achieve.
Known Issue(s)
I only identified one issue and that is the segline, aka binary stream, missing from Lotus, Patriot. I was unable to figure out why, but I think it is ok to ignore that for now. It will very likely fix itself when we merge more of W3D. The segline does show for waypoints.