Skip to content

[Bug]: DnsApp is deleted if manual update archive is malformed #1667

@JCFruit

Description

@JCFruit

Description

When manually updating DnsApp, if archive is malformed (for some reason), Technitium will throw an error (which is ok), but will also delete original version of DNS app with all it's configuration files.

If the same mechanism is used for automatic updates, theoretically it could mean that malformed app archive will delete apps for all users, possibly without them realizing it.

Reproduction steps

  1. Manually add some app to server
  2. Make archive server can't process, for example add password
  3. Manually update app through UI
  4. See error in UI and in logs
  5. After returning to the app page, original app is gone

Log file

Screenshots Installing app Updating app Error in UI Error in logs Original app is gone

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions