-
Notifications
You must be signed in to change notification settings - Fork 84
Query execution pipeline tidying + support for multiple result sets #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NickCraver
merged 16 commits into
StackExchange:master
from
tms:so-i-heard-you-like-resultsets
Jun 19, 2014
Merged
Query execution pipeline tidying + support for multiple result sets #47
NickCraver
merged 16 commits into
StackExchange:master
from
tms:so-i-heard-you-like-resultsets
Jun 19, 2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prevent that in the future
…h, since it *was* needed)
NickCraver
added a commit
that referenced
this pull request
Jun 19, 2014
Query execution pipeline tidying + support for multiple result sets
Contributor
|
Looks good, it's a pretty large changeset though - I'll let this cook on the internal SEDE instances for a day or two before building out data.SE. |
Contributor
Author
|
Sounds like a good idea. I've been trying to keep the changesets reasonably sized, but this ended up being an exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of commits addressing a few key points:
To the last point, a toggle is added to the "Results" tab as appropriate, like the following:

It's not perfect, but it's a starting implementation. TODO items include fixing the CSV results to return the currently toggle result set, adding support for multiple graphs when applicable, adding a way to link to a specific result set, and possibly changing the UI for switching between them.