Skip to content

Conversation

@tms
Copy link
Contributor

@tms tms commented May 13, 2014

A number of commits addressing a few key points:

  • The server-side parameter parser no longer tries to be "clever", making the implementation far less crazy
  • Query-related JavaScript has been refactored and separated so it's not as big of a quagmire, and unused files were removed
  • Rendering of the graphs (and tables, but that's less important) is now deferred, just in case the query triggers the graphing code on results where bad things will happen
  • You can now get back multiple Slick Grid result sets, and we no longer use random jQuery UI styling on them

To the last point, a toggle is added to the "Results" tab as appropriate, like the following:
example

It's not perfect, but it's a starting implementation. TODO items include fixing the CSV results to return the currently toggle result set, adding support for multiple graphs when applicable, adding a way to link to a specific result set, and possibly changing the UI for switching between them.

NickCraver added a commit that referenced this pull request Jun 19, 2014
Query execution pipeline tidying + support for multiple result sets
@NickCraver NickCraver merged commit 4a3e69a into StackExchange:master Jun 19, 2014
@NickCraver
Copy link
Contributor

Looks good, it's a pretty large changeset though - I'll let this cook on the internal SEDE instances for a day or two before building out data.SE.

@tms
Copy link
Contributor Author

tms commented Jun 19, 2014

Sounds like a good idea. I've been trying to keep the changesets reasonably sized, but this ended up being an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants