Skip to content

Conversation

@tms
Copy link
Contributor

@tms tms commented May 8, 2014

Per "Auto-linkification of Tags.TagName fails when the tag name contains nonstandard characters". Adding XRegExp just for this is a tad overkill, but it has some nifty features I want to use elsewhere to clean up some of the JavaScript mess, so bear with me on that one.

@NickCraver
Copy link
Contributor

Can we do this a bit simpler without all the library weight coming into play here?
For example in core the unicode regex check is simply:[^\w#+\-. ]

@tms
Copy link
Contributor Author

tms commented Jun 19, 2014

In JavaScript \w only matches ASCII word characters, which is where the library came into play. I wanted to use some features of the library to potentially clean up other regexes later, but we can handle it either more verbosely client-side or server-side instead if you'd prefer that.

@tms tms closed this Sep 21, 2014
@tms tms deleted the unicoded branch September 21, 2014 00:26
@tms tms restored the unicoded branch September 21, 2014 00:26
@rschrieken
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants