Avoid deadlock in RealMutableStore #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amr Yousef <amr.farid140@gmail.com>
Signed-off-by: Amr Yousef <amr.farid140@gmail.com>
Fixes MobileNativeFoundation#653 and MobileNativeFoundation#654 Signed-off-by: Scott Olcott <scottolcott@gmail.com> Signed-off-by: Amr Yousef <amr.farid140@gmail.com>
This reverts commit 76f34d4. Signed-off-by: Amr Yousef <amr.farid140@gmail.com>
matt-ramotar
approved these changes
Oct 4, 2024
matt-ramotar
pushed a commit
that referenced
this pull request
Feb 19, 2025
* Add test case Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Always Release storeLock Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Update kermit to 2.0.4 (#655) Fixes #653 and #654 Signed-off-by: Scott Olcott <scottolcott@gmail.com> Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Revert "Update kermit to 2.0.4 (#655)" This reverts commit 76f34d4. Signed-off-by: Amr Yousef <amr.farid140@gmail.com> --------- Signed-off-by: Amr Yousef <amr.farid140@gmail.com> Signed-off-by: Scott Olcott <scottolcott@gmail.com> Co-authored-by: Scott Olcott <scottolcott@gmail.com>
itsandreramon
pushed a commit
to itsandreramon/Store
that referenced
this pull request
Feb 26, 2025
* Add test case Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Always Release storeLock Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Update kermit to 2.0.4 (MobileNativeFoundation#655) Fixes MobileNativeFoundation#653 and MobileNativeFoundation#654 Signed-off-by: Scott Olcott <scottolcott@gmail.com> Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Revert "Update kermit to 2.0.4 (MobileNativeFoundation#655)" This reverts commit 76f34d4. Signed-off-by: Amr Yousef <amr.farid140@gmail.com> --------- Signed-off-by: Amr Yousef <amr.farid140@gmail.com> Signed-off-by: Scott Olcott <scottolcott@gmail.com> Co-authored-by: Scott Olcott <scottolcott@gmail.com>
matt-ramotar
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Add test case Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Always Release storeLock Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Update kermit to 2.0.4 (#655) Fixes #653 and #654 Signed-off-by: Scott Olcott <scottolcott@gmail.com> Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Revert "Update kermit to 2.0.4 (#655)" This reverts commit 76f34d4. Signed-off-by: Amr Yousef <amr.farid140@gmail.com> --------- Signed-off-by: Amr Yousef <amr.farid140@gmail.com> Signed-off-by: Scott Olcott <scottolcott@gmail.com> Co-authored-by: Scott Olcott <scottolcott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #657
Description
The change ensures that the store lock is always released from
withThreadSafetyregardless of the execution result ofthreadSafety.block().This helps in avoiding the lock being in a locked state when a cancellation exception is propagated from downstream.
The test mentioned in the issue and added here now passes 100% of the time. Of course happy to delete it (or move it somewhere else) before merging.
Type of Change
Test Plan
See unit test
Checklist:
Before submitting your PR, please review and check all of the following:
Additional Notes:
Add any other information about the PR here.