Skip to content

Conversation

@itsmejoeeey
Copy link
Contributor

@itsmejoeeey itsmejoeeey commented Jan 16, 2023

itsmejoeeey 🐛 Fix Quick itsmejoeeey /BUG/1024_Workspace-trailing-slash → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0

  • Add trailing slash to switch-view-buttons on Workspace sidebar. This prevents a bug when later using switch view buttons on Default/Minimal view switchers.

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Bugfix

Overview

Briefly outline your new changes...

Add trailing slash to switch-view-buttons on Workspace sidebar. This prevents a bug when later using switch view buttons on Default/Minimal view switchers.

Issue Number (if applicable) #1064

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

* Add trailing slash to switch-view-buttons on Workspace sidebar. This prevents a bug when later using switch view buttons on Default/Minimal view switchers.
@itsmejoeeey itsmejoeeey requested a review from Lissy93 as a code owner January 16, 2023 08:40
@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 8ec5f30
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63c50d889c47e4000825a09f
😎 Deploy Preview https://deploy-preview-1066--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 16, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label Feb 4, 2023
@Lissy93 Lissy93 merged commit dc8e651 into Lissy93:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🦋 Bug Fix [PR] Code includes bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants