Skip to content

Allow multiple Project Keys for HealthChecks #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lissy93 merged 1 commit into from
Jan 7, 2023
Merged

Allow multiple Project Keys for HealthChecks #1039

Lissy93 merged 1 commit into from
Jan 7, 2023

Conversation

@m42e
Copy link
Contributor

@m42e m42e commented Jan 7, 2023 •
edited by pull-request-badge bot
Loading

m42e 🚚 Refactor Medium ✅ Ready m42e /multiple-healthcheck-keys → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 43 Unchecked Tasks

Category: Feature

Overview
Allow multiple project keys. to display all checks
And some small formatting improvements (missing states, grid instead of flex for alignment)

Screenshot (if applicable)
Screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added ?

@m42e m42e requested a review from Lissy93 as a code owner January 7, 2023 10:27
@netlify
Copy link

netlify bot commented Jan 7, 2023 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 8e5c378
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63b9492df5c18f000ac04f04
😎 Deploy Preview https://deploy-preview-1039--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 7, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Lissy93
Lissy93 approved these changes Jan 7, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @m42e !

@Lissy93 Lissy93 added 🔀 Ready for Merge [PR] Auto-merge once all status checks have passed 🚚 Refactor [PR] Non-feature code-related updates and refactoring labels Jan 7, 2023
@Lissy93 Lissy93 merged commit 0fc664f into Lissy93:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees

No one assigned

Labels

🔀 Ready for Merge [PR] Auto-merge once all status checks have passed 🚚 Refactor [PR] Non-feature code-related updates and refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m42e @Lissy93