-
Notifications
You must be signed in to change notification settings - Fork 203
Update changed link #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changed link #477
Conversation
spier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the link fix @robtuley!
Also great that you found the bug in the GitHub Action. Great catch!
Looks like we need to look for better ways to test those :)
I left two comments inline where it looks like you changed some markdown formatting that isn't necessarily related to this PR. As part of that is related to the Japanese translation, and I don't speak that language, I am not sure if this will look correct to Japanese readers.
|
Yes my IDE made a mess of that by having a different markdown auto-formatter applying on save to the files I touched. Reverted those auto-changes now so diff should just be 2 x URL corrections and single-line bugfix to PR url checker. |
Awesome. Your fix is merged now. Would there be a way to tell your IDE with markdown formatting we use? |
This PR simply updates a link that has changed. Apologies I should have left a redirect there.
EDIT: the PR link checker status check was failing, so this PR also adds a fix. This looks like it was introduced in #471 but looks like it has a bug in it when multiple *.md files are touched: the
findcommand returns a newline separated list of md files when what is required is a space spearated one so just added a quick fix for that.