Skip to content

Conversation

@fabricecolas
Copy link

@fabricecolas fabricecolas commented Jul 22, 2018

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

UPGRADING.md Outdated
@fortawesome/free-solid-svg-icons \
@fortawesome/free-regular-svg-icons \
@fortawesome/free-brands-svg-icons
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a correct use case because you are adding to your node modules both svg and webfont versions

Copy link
Author

@fabricecolas fabricecolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm install snippet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants