Add serializers for unmodifiable and synchronized collections #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theigl thanks for working on this. Do you already know which version might be shipped with this feature? |
Collaborator
Author
|
Hi @nastra. I'm still unhappy about merging this because it uses terminally deprecated code in |
theigl
force-pushed
the
jdk-collections
branch
from
1df82cb to
d3689ce
Compare
theigl
force-pushed
the
jdk-collections
branch
from
d3689ce to
e460f5d
Compare
# Conflicts: # .github/workflows/pr-workflow.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds serializers for JDK unmodifiable and synchronized collections.
This has been one of the most requested features for Kryo, but I have so far rejected all requests and redirected users to the kryo-serializers project because it is not possible to implement these serializers without reflection. Since this comes up again and again an we already have the same issue with the
ClosureSerializerthat has been part of Kryo for many years, I decided to give up my opposition.The serializers need to be registered manually for now to maintain backwards compatibility, but will be added as default serializers in Kryo 6.
Note: The unsafe logic will probably have to be replaced with Varhandles for JDK24+.
#689
#885
#909
#913
#997
#1022