This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flare.e-rewards.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also https://beta.e-rewards.com
And https://pages.e-rewards.com fails with
not enough values to unpack (expected 2, got 1)And then there are lots of other hosts with errors of all types, including http://oa.e-rewards.com & http://owa.e-rewards.com which are cert errors as the cert is valid for
*.dynata.com, dynata.com, but both of those are "Our website is currently unavailable.".Would this be a reasonable time to use
*.e-rewards.comThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I would rather whitelisting the ruleset for either coverage / fetch test instead of using a wildcard target to avoid tests. This is because there is a lot of different checking performed by Travis important for the ruleset quality. We also discourage wildcard targets unless the domain have a wildcard DNS record, to reduce the long term maintenance effort.
If you would like to keep this ruleset as-is (without adding more hosts), I am ok to merge this given there was incomplete coverage. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given I have 500 odd files to fix, maintainers merging valid fixes rather than requiring I enhance them would be highly appreciated.
Note that using a wildcard was not to avoid tests. It should be very obvious from my contributions that I am trying to get more testing to occur. I would have accompanied a wildcard rule with tests for known working hosts. However the state of this domain is clearly in flux, and/or deteriorating, so IMO it isnt great use of time to document all of the broken hosts which far outnumber the ones which are working.