-
Notifications
You must be signed in to change notification settings - Fork 177
Recreate missing ComfyUI directories during validation #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benceruleanlu
wants to merge
4
commits into
main
Choose a base branch
from
fix/self-heal-missing-dirs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
faa82a5
Recreate missing ComfyUI directories during validation
benceruleanlu 4cfa033
Treat missing requirements as upgrade instead of error
benceruleanlu 470df51
Revert "Treat missing requirements as upgrade instead of error"
benceruleanlu 9933aa5
Add tests for directory self-heal in ComfyInstallation
benceruleanlu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import { beforeEach, describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import { ComfyInstallation } from '@/main-process/comfyInstallation'; | ||
| import type { ITelemetry } from '@/services/telemetry'; | ||
|
|
||
| vi.mock('electron-log/main', () => ({ | ||
| default: { | ||
| info: vi.fn(), | ||
| warn: vi.fn(), | ||
| error: vi.fn(), | ||
| verbose: vi.fn(), | ||
| }, | ||
| })); | ||
|
|
||
| vi.mock('@/virtualEnvironment', () => ({ | ||
| VirtualEnvironment: vi.fn(() => ({})), | ||
| })); | ||
|
|
||
| const createDirectories = vi.fn(); | ||
| const isComfyDirectory = vi.fn(); | ||
|
|
||
| vi.mock('@/config/comfyConfigManager', () => ({ | ||
| ComfyConfigManager: { | ||
| createComfyDirectories: createDirectories, | ||
| isComfyUIDirectory: isComfyDirectory, | ||
| }, | ||
| })); | ||
|
|
||
| vi.mock('@/store/desktopConfig', () => ({ | ||
| useDesktopConfig: vi.fn(() => ({ | ||
| get: vi.fn((key: string) => { | ||
| if (key === 'selectedDevice') return 'cpu'; | ||
| if (key === 'basePath') return '/base/path'; | ||
| return undefined; | ||
| }), | ||
| set: vi.fn(), | ||
| })), | ||
| })); | ||
|
|
||
| vi.mock('@/config/comfySettings', () => ({ | ||
| useComfySettings: vi.fn(() => ({ | ||
| get: vi.fn(), | ||
| set: vi.fn(), | ||
| })), | ||
| ComfySettings: { | ||
| load: vi.fn(), | ||
| }, | ||
| })); | ||
|
|
||
| const telemetry: ITelemetry = { | ||
| track: vi.fn(), | ||
| hasConsent: true, | ||
| flush: vi.fn(), | ||
| registerHandlers: vi.fn(), | ||
| loadGenerationCount: vi.fn(), | ||
| }; | ||
|
|
||
| describe('ComfyInstallation.ensureBaseDirectoryStructure', () => { | ||
| const basePath = '/base/path'; | ||
| let installation: ComfyInstallation; | ||
|
|
||
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| installation = new ComfyInstallation('installed', basePath, telemetry); | ||
| }); | ||
|
|
||
| it('creates and validates directory structure', () => { | ||
| isComfyDirectory.mockReturnValue(true); | ||
|
|
||
| const result = (installation as any).ensureBaseDirectoryStructure(basePath); | ||
|
|
||
| expect(result).toBe(true); | ||
| expect(createDirectories).toHaveBeenCalledWith(basePath); | ||
| expect(isComfyDirectory).toHaveBeenCalledWith(basePath); | ||
| }); | ||
|
|
||
| it('returns false when directory creation throws', () => { | ||
| createDirectories.mockImplementation(() => { | ||
| throw new Error('fail'); | ||
| }); | ||
|
|
||
| const result = (installation as any).ensureBaseDirectoryStructure(basePath); | ||
|
|
||
| expect(result).toBe(false); | ||
| expect(isComfyDirectory).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('returns false when directory validation fails', () => { | ||
| isComfyDirectory.mockReturnValue(false); | ||
|
|
||
| const result = (installation as any).ensureBaseDirectoryStructure(basePath); | ||
|
|
||
| expect(result).toBe(false); | ||
| expect(createDirectories).toHaveBeenCalledWith(basePath); | ||
| expect(isComfyDirectory).toHaveBeenCalledWith(basePath); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second test replaces
createComfyDirectorieswith a throwing implementation (lines 77‑80), but thebeforeEachonly callsvi.clearAllMocks(lines 62‑64), which clears call history without restoring implementations. As a result, the third test still uses the throwing mock and will fail before reachingisComfyDirectory, so the new suite is red as soon as the failing mock is set. Reset the mock implementation (e.g.,mockReset/resetAllMocks) or reassign it per test so the later cases run with the intended behavior.Useful? React with 👍 / 👎.