-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate repository URLs from comfyanonymous to Comfy-Org #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The coreping task was fetching PRs from both comfyanonymous/ComfyUI and Comfy-Org/ComfyUI repos, resulting in duplicate entries in Slack notifications. Added deduplication logic to group PRs by number and prefer Comfy-Org URLs. Also updated REPOLIST to use only Comfy-Org/ComfyUI as the primary source. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates all repository URLs from the old comfyanonymous organization to the new Comfy-Org organization. This is a critical infrastructure change ensuring all GitHub API calls and repository references point to the correct organization.
Key changes:
- Updated repository references in REPOLIST configurations across multiple task files
- Added deduplication logic in coreping task to handle migration from old to new URLs
- Updated documentation and inline comments to reflect the new repository structure
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| run/index.ts | Updated REPOLIST to use Comfy-Org/ComfyUI instead of comfyanonymous/ComfyUI |
| run/gh-bugcop/gh-bugcop.tsx | Updated REPOLIST to use Comfy-Org/ComfyUI instead of comfyanonymous/ComfyUI |
| run/easylabel.tsx | Updated REPOLIST and commented example URL to use Comfy-Org/ComfyUI |
| run/README.md | Updated documentation to reflect Comfy-Org/ComfyUI repository |
| app/tasks/gh-issue-transfer-frontend-to-comfyui/index.ts | Updated destination repository URL and documentation comments |
| app/tasks/gh-issue-transfer-comfyui-to-workflow_templates/index.ts | Updated source repository URL and documentation comments |
| app/tasks/gh-issue-transfer-comfyui-to-frontend/index.ts | Updated source repository URL and documentation comments |
| app/tasks/gh-issue-transfer-comfyui-to-desktop/index.ts | Updated source repository URL and documentation comments |
| app/tasks/gh-desktop-release-notification/index.ts | Updated repos configuration to use Comfy-Org/ComfyUI |
| app/tasks/gh-core-tag-notification/index.ts | Updated repo configuration to use Comfy-Org/ComfyUI |
| app/tasks/coreping/coreping.ts | Updated REPOLIST, added deduplication logic, and updated example URLs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/tasks/coreping/coreping.ts
Outdated
| // Deduplicate PRs by number, preferring Comfy-Org/ComfyUI over comfyanonymous/ComfyUI | ||
| const seenPRNumbers = new Map<number, GH["pull-request-simple"]>(); | ||
| for (const pr of allPRs) { | ||
| const existingPR = seenPRNumbers.get(pr.number); | ||
| if (!existingPR) { | ||
| seenPRNumbers.set(pr.number, pr); | ||
| } else { | ||
| // Prefer Comfy-Org/ComfyUI URLs over comfyanonymous/ComfyUI | ||
| if (pr.html_url.includes("Comfy-Org/ComfyUI") && !existingPR.html_url.includes("Comfy-Org/ComfyUI")) { | ||
| seenPRNumbers.set(pr.number, pr); | ||
| } | ||
| } | ||
| } | ||
| const deduplicatedPRs = Array.from(seenPRNumbers.values()); |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This inline deduplication logic has the same issue as the deduplicatePRTasks function - it uses only PR number as the key without considering the repository. Since the REPOLIST contains multiple repositories (ComfyUI, Comfy-PR, ComfyUI_frontend, desktop), PR #123 from ComfyUI will incorrectly deduplicate with PR #123 from desktop or any other repository. Additionally, since the REPOLIST no longer includes "comfyanonymous/ComfyUI", the preference logic at line 329 will never execute. This entire inline deduplication block (lines 321-334) should likely be removed, or the deduplication key should include the repository name.
| // Deduplicate PRs by number, preferring Comfy-Org/ComfyUI over comfyanonymous/ComfyUI | |
| const seenPRNumbers = new Map<number, GH["pull-request-simple"]>(); | |
| for (const pr of allPRs) { | |
| const existingPR = seenPRNumbers.get(pr.number); | |
| if (!existingPR) { | |
| seenPRNumbers.set(pr.number, pr); | |
| } else { | |
| // Prefer Comfy-Org/ComfyUI URLs over comfyanonymous/ComfyUI | |
| if (pr.html_url.includes("Comfy-Org/ComfyUI") && !existingPR.html_url.includes("Comfy-Org/ComfyUI")) { | |
| seenPRNumbers.set(pr.number, pr); | |
| } | |
| } | |
| } | |
| const deduplicatedPRs = Array.from(seenPRNumbers.values()); | |
| // Deduplicate PRs by repository and number using the unique HTML URL as key | |
| const seenPRs = new Map<string, GH["pull-request-simple"]>(); | |
| for (const pr of allPRs) { | |
| const prKey = pr.html_url; | |
| if (!seenPRs.has(prKey)) { | |
| seenPRs.set(prKey, pr); | |
| } | |
| } | |
| const deduplicatedPRs = Array.from(seenPRs.values()); |
app/tasks/coreping/coreping.ts
Outdated
| function deduplicatePRTasks<T extends { url: string }>(tasks: T[]): T[] { | ||
| const seenPRNumbers = new Map<number, T>(); | ||
| for (const task of tasks) { | ||
| const prNumber = Number(task.url.split("/").pop()); | ||
| if (isNaN(prNumber)) continue; | ||
|
|
||
| const existingTask = seenPRNumbers.get(prNumber); | ||
| if (!existingTask) { | ||
| seenPRNumbers.set(prNumber, task); | ||
| } else { | ||
| // Prefer Comfy-Org/ComfyUI URLs over comfyanonymous/ComfyUI | ||
| if (task.url.includes("Comfy-Org/ComfyUI") && !existingTask.url.includes("Comfy-Org/ComfyUI")) { | ||
| seenPRNumbers.set(prNumber, task); | ||
| } | ||
| } | ||
| } | ||
| return Array.from(seenPRNumbers.values()); | ||
| } |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deduplication logic assumes PR numbers extracted from URLs are unique identifiers across different repositories. However, PR number 123 in "Comfy-Org/desktop" is completely different from PR number 123 in "Comfy-Org/ComfyUI". This function will incorrectly deduplicate unrelated PRs that happen to share the same number. The deduplication should include the repository name in the key, not just the PR number. For example, use a composite key like "Comfy-Org/ComfyUI#123" instead of just "123".
…ns and improving readability (#140) feat(coreping.ts): add filtering for deprecated comfyanonymous/ComfyUI URLs to prevent showing stale data fix(coreping.ts): restore deduplication logic for PR tasks to prefer Comfy-Org/ComfyUI URLs
- Fixed deduplicatePRTasks to use html_url as unique key - Fixed inline deduplication logic to use html_url instead of PR number - Resolved merge conflicts from recent updates - Addresses Copilot review comments about incorrect deduplication This fixes the issue where PR #123 from different repositories (e.g., ComfyUI vs desktop) were incorrectly deduplicated. Now each PR is uniquely identified by its full html_url across all repositories. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This PR updates all repository URLs from the old comfyanonymous organization to the new Comfy-Org organization.
Changes include:
Bug Fixes:
Data Migration:
All URL-based indexing has been updated to:
This ensures all GitHub API calls and repository references point to the correct organization while maintaining data integrity.