CMake: Set CMake to 3.10...3.19 range for !WIN32 #2437
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise !WIN32 minimum mildly from 3.9 to 3.10, which was released in 2017. If Windows build can deal with 3.19, so should others. This enables policy level up to 3.19 when using modern versions of CMake. Fixes CMake 3.31 warning: > CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): > Compatibility with CMake < 3.10 will be removed from a future version of > CMake. > > Update the VERSION argument <min> value. Or, use the <min>...<max> syntax > to tell CMake that the project requires at least <min> but has been updated > to work with policies introduced by <max> or earlier. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Collaborator
|
According to Debian package search, Debian 11 has cmake 3.18, so maybe we should just set that as a minimum version regardless of platform. (Windows needs 3.19 for some of the DLL copying, but having 3.18 in the directive shouldn't be an issue there.) @375gnu - thoughts? |
375gnu
approved these changes
Jan 9, 2026
Collaborator
|
Personally I'm not a fan of using the latest tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise !WIN32 minimum mildly from 3.9 to 3.10, which was released in 2017. If Windows build can deal with 3.19, so should others. This enables policy level up to 3.19 when using modern versions of CMake.
Fixes CMake 3.31 warning: