Skip to content

Conversation

@AllaMaevskaya
Copy link
Contributor

No description provided.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AllaMaevskaya , please see a few comments below.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave the ACO last, just reassign T0=11, V0=12, FIT=13 and ACO=14

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And propagate the same to names

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and masks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you nee o2::fit namespace declaration here? Below you use explicitly o2::fit::Digit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the macros relying on the FairRunAna chain. The DPL digitizer-workflow should be used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be sure: what is the reason to have common V0,T0 digits (under the fit namespace) and separate RecPoints?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the HitType.h the HitType is defined in the o2::namespace, as well as in many places below.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above the V0 derives its own Hit class directly from the BasicXYZEHit. If this class is for T0 only, why is it in the common dir.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants