fix: boolean overrides with assemble's include key #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2025 18:07
Fixes 89luca89#1940. The issue arose from handling of cumulative keys like `additional_packages` or `additional_flags` being applied to boolean flags as well.
givensuman
force-pushed
the
T-1940-fix-assemble-include
branch
2 times, most recently
from
668d82e to
a0521ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1940.
The issue arose from handling of cumulative keys like
additional_packagesoradditional_flagsbeing applied to booleanflags as well.
Also includes a small patch for the leading spaces in
--additional-packagesoutput's leading space mentioned in #1940.Testing
then run
./distrobox-assemble create --dry-run --file bug.ini. This satisfies expected output:./distrobox-create --yes --name ubuntu --image ubuntu:latest --root --additional-packages zsh ./distrobox-create --yes --name ubuntu-nvidia --image ubuntu:latest --nvidia --additional-packages "zsh htop iotop"