From bbabe69bf249e11bd0949a835bb3e01d9be92737 Mon Sep 17 00:00:00 2001 From: jxom Date: Mon, 9 Oct 2017 20:58:52 +1100 Subject: [PATCH 1/3] Add script for check-all in CI --- package.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 13be6a02bf4..831205c4ef0 100644 --- a/package.json +++ b/package.json @@ -68,11 +68,12 @@ }, "scripts": { "build": "gatsby build", - "check-all": "yarn prettier && yarn lint && yarn flow", + "check-all": "yarn prettier -- --write && yarn lint && yarn flow", + "check-all:verbose": "yarn prettier -- --list-different && yarn lint && yarn flow", "dev": "gatsby develop -H 0.0.0.0", "lint": "eslint .", "netlify": "yarn install && yarn build", - "prettier": "prettier --config .prettierrc --write '{flow-typed,plugins,src}/**/*.js'", + "prettier": "prettier --config .prettierrc '{flow-typed,plugins,src}/**/*.js'", "reset": "rimraf ./.cache" }, "devDependencies": { From d26cf5f86c7ad01893c44efea7f035e29fd2cf7b Mon Sep 17 00:00:00 2001 From: jxom Date: Mon, 9 Oct 2017 21:04:29 +1100 Subject: [PATCH 2/3] Add prettier:diff script --- package.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 831205c4ef0..8c18ca1b0ff 100644 --- a/package.json +++ b/package.json @@ -68,12 +68,13 @@ }, "scripts": { "build": "gatsby build", - "check-all": "yarn prettier -- --write && yarn lint && yarn flow", - "check-all:verbose": "yarn prettier -- --list-different && yarn lint && yarn flow", + "check-all": "yarn prettier && yarn lint && yarn flow", + "check-all:verbose": "yarn prettier:diff && yarn lint && yarn flow", "dev": "gatsby develop -H 0.0.0.0", "lint": "eslint .", "netlify": "yarn install && yarn build", - "prettier": "prettier --config .prettierrc '{flow-typed,plugins,src}/**/*.js'", + "prettier": "prettier --config .prettierrc --write '{flow-typed,plugins,src}/**/*.js'", + "prettier:diff": "prettier --config .prettierrc --list-different '{flow-typed,plugins,src}/**/*.js'", "reset": "rimraf ./.cache" }, "devDependencies": { From 5a96b1da0336ec8ad85b59296896a7fcd501c7e9 Mon Sep 17 00:00:00 2001 From: jxom Date: Tue, 10 Oct 2017 08:22:12 +1100 Subject: [PATCH 3/3] Rename check-all:verbose to ci-check, add some useful eslint config --- .eslintrc | 10 +++++++++- package.json | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.eslintrc b/.eslintrc index 78354d1e389..28d87f00ef3 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,7 +1,15 @@ { + "extends": [ + "eslint:recommended", + "plugin:react/recommended" + ], "plugins": [ "prettier", "react" ], "parser": "babel-eslint", -} \ No newline at end of file + "env": { + "node": true, + "browser": true + } +} diff --git a/package.json b/package.json index 8c18ca1b0ff..8541b89cd15 100644 --- a/package.json +++ b/package.json @@ -69,7 +69,7 @@ "scripts": { "build": "gatsby build", "check-all": "yarn prettier && yarn lint && yarn flow", - "check-all:verbose": "yarn prettier:diff && yarn lint && yarn flow", + "ci-check": "yarn prettier:diff && yarn lint && yarn flow", "dev": "gatsby develop -H 0.0.0.0", "lint": "eslint .", "netlify": "yarn install && yarn build",