JWT exposed when pasting images

[aevyrie]

Select Topic Area

Product Feedback

Body

No idea where else to report a potential GH security problem, but I've noticed that pasting images often exposes a user's JWT in the image URL. Even if short lived, this seems like a security issue? Regardless, seeing jwt=123abc when pasting a screenshot in a public PR doesn't give me the warm fuzzies.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[calilkhalil]

Hey, you're right to be concerned here, JWTs showing up in public image URLs definitely shouldn't happen, even if they're short-lived. That's a real security issue, not just a product quirk.

The thing is, this got routed to the general feedback queue where it'll just get a bot response (as you saw). Security stuff needs to go somewhere it'll actually get looked at:

• https://hackerone.com/github — their bug bounty program
• security@github.com — direct line to the security team

They'll actually investigate whether those tokens are properly scoped and short-lived enough, or if this needs a fix. Plus, if it's a legit vulnerability, you might get a bounty out of it.

Until then, maybe hold off on pasting screenshots in public PRs if you can help it.