From 29815b3c31f9eba712fb04a181a9fe7f46b114fc Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Sun, 31 Jan 2021 20:24:49 +0530 Subject: [PATCH 1/2] test: remove outdated V8 flag The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. Refs: https://github.com/v8/v8/commit/0a480c30d553c1b8dddb0dddcbdec5fb6f3101ff --- test/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/index.js b/test/index.js index 2d963ca10..ddf09d708 100644 --- a/test/index.js +++ b/test/index.js @@ -4,7 +4,7 @@ const majorNodeVersion = process.versions.node.split('.')[0]; if (typeof global.gc !== 'function') { // Construct the correct (version-dependent) command-line args. - let args = ['--expose-gc', '--no-concurrent-array-buffer-freeing']; + let args = ['--expose-gc']; if (majorNodeVersion >= 14) { args.push('--no-concurrent-array-buffer-sweeping'); } From 1d8a73d92224ad701ae8f9b50846b19e4607db74 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Wed, 3 Feb 2021 20:44:51 +0530 Subject: [PATCH 2/2] fixup! test: remove outdated V8 flag --- test/index.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/index.js b/test/index.js index ddf09d708..35db3187b 100644 --- a/test/index.js +++ b/test/index.js @@ -5,6 +5,10 @@ const majorNodeVersion = process.versions.node.split('.')[0]; if (typeof global.gc !== 'function') { // Construct the correct (version-dependent) command-line args. let args = ['--expose-gc']; + const majorV8Version = process.versions.v8.split('.')[0]; + if (majorV8Version < 9) { + args.push('--no-concurrent-array-buffer-freeing'); + } if (majorNodeVersion >= 14) { args.push('--no-concurrent-array-buffer-sweeping'); }