Set constrain in clone (not apply)

Only set if the transform's constrain differs from its defaultConstrain

Author: larsmaxfield

src/geo/projection/globe_transform.ts

@@ -265,6 +265,7 @@ export class GlobeTransform implements ITransform {
 
     clone(): ITransform {
         const clone = new GlobeTransform();
+        if (this.constrain !== this.defaultConstrain) clone.setConstrain(this.constrain);
         clone._globeness = this._globeness;
         clone._globeLatitudeErrorCorrectionRadians = this._globeLatitudeErrorCorrectionRadians;
         clone.apply(this);

src/geo/projection/mercator_transform.ts

@@ -253,6 +253,7 @@ export class MercatorTransform implements ITransform {
 
     public clone(): ITransform {
         const clone = new MercatorTransform();
+        if (this.constrain !== this.defaultConstrain) clone.setConstrain(this.constrain);
         clone.apply(this);
         return clone;
     }

src/geo/projection/vertical_perspective_transform.ts

@@ -268,6 +268,7 @@ export class VerticalPerspectiveTransform implements ITransform {
 
     clone(): ITransform {
         const clone = new VerticalPerspectiveTransform();
+        if (this.constrain !== this.defaultConstrain) clone.setConstrain(this.constrain);
         clone.apply(this);
         return clone;
     }

src/geo/transform_helper.test.ts

@@ -14,9 +14,6 @@ const emptyCallbacks = {
 describe('TransformHelper', () => {
     test('apply', () => {
         const original = new TransformHelper(emptyCallbacks);
-        original.setConstrain((lngLat, zoom) => {
-            return {center: lngLat, zoom: zoom ?? 0};
-        });
         original.setBearing(12);
         original.setCenter(new LngLat(3, 4));
         original.setElevation(5);
@@ -42,7 +39,6 @@ describe('TransformHelper', () => {
         cloned.apply(original);
 
         // Check all getters from the ITransformGetters interface
-        expect(cloned.constrain).toEqual(original.constrain);
         expect(cloned.tileSize).toEqual(original.tileSize);
         expect(cloned.tileZoom).toEqual(original.tileZoom);
         expect(cloned.scale).toEqual(original.scale);

src/geo/transform_helper.ts

@@ -185,7 +185,6 @@ export class TransformHelper implements ITransformGetters {
     }
 
     public apply(thatI: ITransformGetters, constrain?: boolean, forceOverrideZ?: boolean): void {
-        this._constrain = thatI.constrain;
         this._latRange = thatI.latRange;
         this._lngRange = thatI.lngRange;
         this._width = thatI.width;