From b4aafe48a0fd0f0c48fc7f81e1c05d3ad6f8001c Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Wed, 26 Feb 2025 12:49:59 -0800 Subject: [PATCH 1/6] use `plugins` block for rubocop-performance and rubocop-rails --- config/default.yml | 2 ++ config/rails.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/config/default.yml b/config/default.yml index 52d44625..cf5d193e 100644 --- a/config/default.yml +++ b/config/default.yml @@ -3,6 +3,8 @@ inherit_from: require: - rubocop-github + +plugins: - rubocop-performance Bundler/DuplicatedGem: diff --git a/config/rails.yml b/config/rails.yml index b7b8d6ec..80458562 100644 --- a/config/rails.yml +++ b/config/rails.yml @@ -3,6 +3,8 @@ inherit_from: require: - rubocop-github-rails + +plugins: - rubocop-rails GitHub/RailsControllerRenderActionSymbol: From 0bdf2d7a020fb1290513ecf41aaf8e93d167d6af Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Wed, 26 Feb 2025 13:35:04 -0800 Subject: [PATCH 2/6] bump the required version of rubocop to 1.72 or higher --- Gemfile.lock | 2 +- rubocop-github.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index d4bfa04e..970dabc1 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,7 +2,7 @@ PATH remote: . specs: rubocop-github (0.22.0) - rubocop (>= 1.37) + rubocop (>= 1.72) rubocop-performance (>= 1.15) rubocop-rails (>= 2.17) diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec index 8f0f0ef4..eaa7b09b 100644 --- a/rubocop-github.gemspec +++ b/rubocop-github.gemspec @@ -20,7 +20,7 @@ Gem::Specification.new do |s| s.required_ruby_version = ">= 3.0.0" - s.add_dependency "rubocop", ">= 1.37" + s.add_dependency "rubocop", ">= 1.72" s.add_dependency "rubocop-performance", ">= 1.15" s.add_dependency "rubocop-rails", ">= 2.17" From d24171b3857dd0b8ac19de6cf754abef87ea291c Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Wed, 26 Feb 2025 13:35:44 -0800 Subject: [PATCH 3/6] bump version to 0.23.0 --- CHANGELOG.md | 4 ++++ Gemfile.lock | 2 +- lib/version.rb | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bf2db2f4..2496c68f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # rubocop-github +## v0.23.0 + +- Read the automatic release notes on [the /releases page for this gem](https://github.com/github/rubocop-github/releases). + ## v0.22.0 - Read the automatic release notes on [the /releases page for this gem](https://github.com/github/rubocop-github/releases). diff --git a/Gemfile.lock b/Gemfile.lock index 970dabc1..27f2dcb7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - rubocop-github (0.22.0) + rubocop-github (0.23.0) rubocop (>= 1.72) rubocop-performance (>= 1.15) rubocop-rails (>= 2.17) diff --git a/lib/version.rb b/lib/version.rb index 3ed48bc6..fd3043d4 100644 --- a/lib/version.rb +++ b/lib/version.rb @@ -1,3 +1,3 @@ # frozen_string_literal: true -VERSION = "0.22.0" +VERSION = "0.23.0" From 4a91e3523bd6d24afc7e9362e3a149e27c09d29c Mon Sep 17 00:00:00 2001 From: Grant Birkinbine Date: Wed, 26 Feb 2025 23:13:51 -0800 Subject: [PATCH 4/6] Update rubocop-github.gemspec Co-authored-by: Koichi ITO --- rubocop-github.gemspec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec index eaa7b09b..18b5aff9 100644 --- a/rubocop-github.gemspec +++ b/rubocop-github.gemspec @@ -21,8 +21,8 @@ Gem::Specification.new do |s| s.required_ruby_version = ">= 3.0.0" s.add_dependency "rubocop", ">= 1.72" - s.add_dependency "rubocop-performance", ">= 1.15" - s.add_dependency "rubocop-rails", ">= 2.17" + s.add_dependency "rubocop-performance", ">= 1.24" + s.add_dependency "rubocop-rails", ">= 2.23" s.add_development_dependency "actionview", "~> 7.1.5.1" s.add_development_dependency "minitest" From a841e05fb7fec8135599c68df6c0bff2ff4d12a1 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Wed, 26 Feb 2025 23:14:17 -0800 Subject: [PATCH 5/6] run bundle install --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 27f2dcb7..3f465d14 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -3,8 +3,8 @@ PATH specs: rubocop-github (0.23.0) rubocop (>= 1.72) - rubocop-performance (>= 1.15) - rubocop-rails (>= 2.17) + rubocop-performance (>= 1.24) + rubocop-rails (>= 2.23) GEM remote: https://rubygems.org/ From 26fee530f96260296891dafe1d0b8d0c09d3d63f Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Wed, 26 Feb 2025 23:14:36 -0800 Subject: [PATCH 6/6] run bundle update --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 3f465d14..8c60f672 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -75,7 +75,7 @@ GEM rainbow (3.1.1) rake (13.2.1) regexp_parser (2.10.0) - rubocop (1.72.2) + rubocop (1.73.0) json (~> 2.3) language_server-protocol (~> 3.17.0.2) lint_roller (~> 1.1.0) @@ -86,7 +86,7 @@ GEM rubocop-ast (>= 1.38.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 4.0) - rubocop-ast (1.38.0) + rubocop-ast (1.38.1) parser (>= 3.3.1.0) rubocop-performance (1.24.0) lint_roller (~> 1.1)