Merge pull request #20908 from emberjs/glimmervm-submodule

Working toward glimmer-vm repo integration

Author: ef4

.env.development

@@ -0,0 +1 @@
+VM_LOCAL_DEV = true

.github/workflows/alpha-releases.yml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           persist-credentials: false
-      - uses: ./.github/actions/setup  
+      - uses: ./.github/actions/setup
       - name: setup git
         run: |
           git config --local user.email 'tomster@emberjs.com'
@@ -33,7 +33,7 @@ jobs:
       - name: bump version
         run: npm version ${{env.NEXT_ALPHA}} --allow-same-version --no-git-tag-version
       - name: create tag
-        run: git tag v${{env.NEXT_ALPHA}}-ember-source    
+        run: git tag v${{env.NEXT_ALPHA}}-ember-source
       - name: push tag
         # Push in a way that WILL trigger other workflows
-        run: git push https://${GITHUB_ACTOR}:${{ secrets.PERSONAL_TOKEN }}@github.com/${GITHUB_REPOSITORY} v${{env.NEXT_ALPHA}}-ember-source       
+        run: git push https://${GITHUB_ACTOR}:${{ secrets.PERSONAL_TOKEN }}@github.com/${GITHUB_REPOSITORY} v${{env.NEXT_ALPHA}}-ember-source

.github/workflows/ci-jobs.yml

@@ -5,7 +5,7 @@ on:
 
 permissions:
   contents: read
-  
+
 jobs:
   lint:
     name: Linting
@@ -31,26 +31,28 @@ jobs:
       - uses: ./.github/actions/setup
       - name: build types
         run: pnpm build:types
-      - name: Check published and internal types
-        run: pnpm type-check
-        
+      - name: Check internal types
+        run: pnpm type-check:internals
+      - name: Check published types
+        run: pnpm type-check:types
+
   types-range:
     name: Type Checking (other supported versions)
     runs-on: ubuntu-latest
-    needs: [ 'types' ]
+    needs: ["types"]
     strategy:
       matrix:
-        ts-version: [ '5.2', '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9' ]
+        ts-version: ["5.2", "5.3", "5.4", "5.5", "5.6", "5.7", "5.8", "5.9"]
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/setup
       - name: build stable type definitions
         run: pnpm build:types
       - name: install TS@${{matrix.ts-version}}
         run: pnpm add --save-dev --workspace-root typescript@${{ matrix.ts-version }}
-      - name: Check published and internal types with TS@${{matrix.ts-version}}
-        run: pnpm type-check
-        
+      - name: Check published types
+        run: pnpm type-check:types
+
   basic-test:
     name: Basic Test
     runs-on: ubuntu-latest
@@ -59,14 +61,17 @@ jobs:
       - uses: ./.github/actions/setup
       - name: build
         run: pnpm vite build --mode=development
+        env:
+          NODE_ENV: development
       - name: test
         run: pnpm test
-        
+
   variant-tests:
     name: ${{ matrix.name }}
     runs-on: ubuntu-latest
-    needs: [ basic-test, lint, types ]
+    needs: [basic-test, lint, types]
     strategy:
+      fail-fast: false
       matrix:
         include:
           - name: "All deprecations enabled"
@@ -90,6 +95,8 @@ jobs:
       - uses: ./.github/actions/setup
       - name: build
         run: pnpm vite build --mode=${{ matrix.BUILD || 'development' }}
+        env:
+          NODE_ENV: ${{ matrix.BUILD || 'development' }}
       - name: test
         env:
           ALL_DEPRECATIONS_ENABLED: ${{ matrix.ALL_DEPRECATIONS_ENABLED }}
@@ -98,17 +105,18 @@ jobs:
           RAISE_ON_DEPRECATION: ${{ matrix.RAISE_ON_DEPRECATION }}
 
         run: pnpm test
-                  
+
   browserstack-test:
     name: Browserstack Tests (Safari, Edge)
     runs-on: ubuntu-latest
-    needs: [ basic-test, lint, types ]
+    needs: [basic-test, lint, types]
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/setup
       - name: build
         env:
           ALL_SUPPORTED_BROWSERS: true
+          NODE_ENV: development
         run: pnpm vite build --mode=development
 
       - name: Set BrowserStack Local Identifier

.github/workflows/publish-to-npm.yml

@@ -4,7 +4,7 @@ on:
   push:
     tags:
       - 'v*'
-        
+
 jobs:
   tests:
     uses: ./.github/workflows/ci-jobs.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [ tests ]
     permissions:
-      contents: read 
+      contents: read
       id-token: write
     steps:
       - uses: actions/checkout@v4
@@ -29,7 +29,7 @@ jobs:
           OVERRIDE_FEATURES: ''
         run: node bin/build-for-publishing.js
       - name: Build for Publish
-        if: ${{ !contains(github.ref, 'alpha') }}      
+        if: ${{ !contains(github.ref, 'alpha') }}
         run: node bin/build-for-publishing.js
       - name: publish to npm
         run: npm publish
@@ -58,6 +58,6 @@ jobs:
           webhook: ${{ secrets.FRAMEWORK_WEBHOOK }}
           status: 'Success'
           title: 'Released ember-source ${{ github.ref_name }}'
-          color: 0x2ecc71        
+          color: 0x2ecc71
           url: '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}'
           username: GitHub Actions

.prettierignore

@@ -10,3 +10,5 @@ docs/
 CHANGELOG.md
 package.json
 pnpm-lock.yaml
+glimmer-vm/**/*.md
+glimmer-vm/**/*.yaml

babel.config.mjs

@@ -29,7 +29,7 @@ export default {
       {
         compilerPath: resolve(
           dirname(fileURLToPath(import.meta.url)),
-          './broccoli/glimmer-template-compiler'
+          './broccoli/glimmer-template-compiler.mjs'
         ),
       },
     ],

babel.test.config.mjs

@@ -8,7 +8,6 @@
 */
 
 import { createRequire } from 'node:module';
-import vmBabelPlugins from '@glimmer/vm-babel-plugins';
 import baseConfig from './babel.config.mjs';
 
 // eslint-disable-next-line no-redeclare
@@ -28,9 +27,5 @@ export default {
     ],
   ],
 
-  plugins: [
-    ...baseConfig.plugins,
-    buildDebugMacroPlugin(!isProduction),
-    ...vmBabelPlugins({ isDebug: !isProduction }),
-  ],
+  plugins: [...baseConfig.plugins, buildDebugMacroPlugin(!isProduction)],
 };

bin/link-glimmer-vm-packages.mjs

@@ -48,7 +48,7 @@ import nodeGzip from 'node-gzip';
 import { join } from 'node:path';
 import { readFileSync, writeFileSync } from 'node:fs';
 import { minify } from 'terser';
-import { transformSync } from '@babel/core';
+import { transformAsync } from '@babel/core';
 import * as brotli from 'brotli';
 import { partial } from 'filesize';
 const size = partial({ standard: 'jedec' });
@@ -94,10 +94,12 @@ for (const pkg of packages) {
 
   for (let file of jsFiles) {
     let source = readFileSync(file, 'utf8');
-    let transformed = transformSync(source, {
-      ...babelOptions,
-      filename: file,
-    }).code;
+    let transformed = (
+      await transformAsync(source, {
+        ...babelOptions,
+        filename: file,
+      })
+    ).code;
     let result = await minify(transformed, {
       module: true,
       mangle: false,